remove unnecessary black border above and below video in player #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci failure seems unrelated (docker pull error - probably a temporary network issue) |
rigelk
added
Component: Player ⏯️
UI
rigelk
requested changes
Apr 4, 2021
to remove unnecessary black border above and below the video Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
violoncelloCH
force-pushed
the
fix/player-width-height-ratio
branch
from
8d0ee86
to
d8e33e7
Compare
|
Nice! Thanks @violoncelloCH |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the unnecessary black border/space above and below the video in normal player mode (if browser window is wide). It's achieved by further precising the aspect ratio 16/9 which is not just 1.7, but ~1.777777778. Therefore the video control take a little less vertical space and a 16/9 video fits perfectly into the same space. (see Screenshots below)
Related issues
none AFAIK
Has this been tested?
visual difference can be seen on Screenshots below
Screenshots