Reducing tag input excessive padding; fixes #3915 #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rigel Kent <par@rigelk.eu>
|
Hi @rigelk , happy to help. I compressed the selectors as you requested. |
rigelk
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the use of
!importantthat caused this issue, and specified rules more in line withtheme.default.cssto minimize overrides and unnecessary rules to ensure tag input fields do not have excessive padding. Ensured entered tags have a3pxmargin on the left to maintain their positioning (because.ng-inputgets3pxpadding by default already).Related issues
Fixes #3915.
Has this been tested?
Visually inspected the following relevant input fields in Firefox and a Chrome-based browser (screenshots below, in order listed):
!importantseemed to be intended)Screenshots