Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding frontend peertubeHelpers.getBaseRouterRoute. #4153

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

JohnXLivingston
Copy link
Contributor

Description

As discussed in private with @Chocobozzz , here is the frontend version for peertubeHelpers.getBaseRouterRoute.

For the documentation part, I did not know which peertube version to mention. 3.3.0 ? 4.0.0 ? other?

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 👍 yes, light tests as follows are enough
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

There is no test file for this front-end code.
I tested with one of my plugin (see commit JohnXLivingston/peertube-plugin-livechat@22f392d )

@Chocobozzz
Copy link
Owner

3.3 👍

But I think there is something wrong in the doc toc command, - [Plugins & Themes](#plugins--themes) should not be included

@JohnXLivingston
Copy link
Contributor Author

But I think there is something wrong in the doc toc command, - [Plugins & Themes](#plugins--themes) should not be included

I have no idea how doc toc works. I only added lines outside the doctoc block, and run a npm run build. And then I got this diff.

@JohnXLivingston
Copy link
Contributor Author

I fixed the doctoc.

I don't understand how it works. When I edit with Visual Studio Code, it auto-generates wrongly this part. I don't know how to disable, nor to configure. There is nothing like «doctoc» in the settings or plugins.

@JohnXLivingston
Copy link
Contributor Author

Ok, I found the settings in Visual Studio Code: Markdown > Extension > Toc: update on save.

@Chocobozzz
Copy link
Owner

Thanks @JohnXLivingston

@Chocobozzz Chocobozzz merged commit 9777fe9 into Chocobozzz:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants