prevent multiple post-process triggering of upload-resumable #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
force-pushed
the
prevent-multiple-resumable-put
branch
6 times, most recently
from
d111523
to
0ce2345
Compare
rigelk
force-pushed
the
prevent-multiple-resumable-put
branch
from
0ce2345
to
0cd0f98
Compare
rigelk
force-pushed
the
prevent-multiple-resumable-put
branch
2 times, most recently
from
e4a15d4
to
5c0923d
Compare
rigelk
force-pushed
the
prevent-multiple-resumable-put
branch
from
5c0923d
to
ed54e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last PUT request should only be trigger-able once, whatever the situation.
This PR keeps track of the
upload_idbeing processed, and answer a 503 Service Unavailable on later PUT requests made for the sameupload_id. Once the video upload has finished processing, it stores the response and doesn't delete the associated meta file for 15 min, allowing for other requests to be responded with the final response of the initial request instead of the 503 during that timeframe.Related issues
fixes #4173
Has this been tested?