Support proxies for PeerTube #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilekison
changed the title
smilekison
changed the title
Chocobozzz
requested changes
Aug 24, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is made to solve the issue in response to #4202. This functionality is useful for the corporate office who wish to run PeerTube behind the Proxy environment. With this update, the PeerTube checks for the availability of proxy addresses in the OS Environment. The process in which PeerTube runs is as follow:
Corporate offices can run PeerTube behind Proxy by providing HTTPS_PROXY or HTTP_PROXY (case sensitive: must be UPPERCASE & in URL format) in the OS environment variable.
If the Proxy variable is not set in the OS Environment, the PeerTube runs without proxy.
We have already shared the detailed version of Architecture and the code in the respective issue and we got approval to create a pull request by the owner of PeerTube. We have tested the application with test coverage and the respective documentation can be found in the following link.
https://docs.google.com/document/d/1Hg7fKbGnAqPmZsfbzvozH36LjGkmnqITK0oAxntBv4o/edit?usp=sharing
Related issues
Fixes #4202
Has this been tested?
Co-authored-by: Sijan Bhattarai bhattaraisijan@outlook.com
Co-authored-by: Julesh Shrestha juliusshrestha29@gmail.com
Co-authored-by: Durgaraj Karki raazkarkee405@gmail.com