Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to always show channel display name #4422

Merged
merged 5 commits into from
Oct 12, 2021
Merged

add option to always show channel display name #4422

merged 5 commits into from
Oct 12, 2021

Conversation

kontrollanten
Copy link
Contributor

@kontrollanten kontrollanten commented Sep 20, 2021 •
edited
Loading

Description

  • Add avatar in video miniatures (Discover, Trending, Recently added and Local videos).
  • Adds following configuration options:
instance.onlyShowAuthorChannel
instance.showAuthorDisplayNameInMiniatures

Related issues

closes #4040

Has this been tested?

  • 🙅 no, because this PR does not update server code

Screenshots

image
image
image

@kontrollanten kontrollanten marked this pull request as draft September 20, 2021 08:42
@kontrollanten kontrollanten marked this pull request as ready for review September 21, 2021 08:25
Chocobozzz
Chocobozzz requested changes Oct 8, 2021
View reviewed changes
Copy link
Owner

@Chocobozzz Chocobozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but I don't want to maintain onlyShowAuthorChannel configuration.

We already have enough complexity in these components. You'll have to reproduce this behaviour using a plugin

client/src/app/shared/shared-video-miniature/video-miniature.component.html Outdated Show resolved Hide resolved
client/src/app/shared/shared-video-miniature/video-miniature.component.html Outdated Show resolved Hide resolved
config/default.yaml Outdated Show resolved Hide resolved
client/src/app/shared/shared-video-miniature/video-miniature.component.ts Outdated Show resolved Hide resolved
@Chocobozzz
Copy link
Owner

Thanks @kontrollanten

I just renamed the config key to prefer_author_display_name and added a small comment.

@Chocobozzz Chocobozzz merged commit 7399a79 into Chocobozzz:develop Oct 12, 2021
@kontrollanten kontrollanten deleted the feat_4040/user_display_name branch October 12, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobozzz Chocobozzz Awaiting requested review from Chocobozzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin configuration to display actor username/display name for miniatures
2 participants
@kontrollanten @Chocobozzz