Add video transcoding_failed state #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontrollanten
force-pushed
the
feat-4500-tranascoding-failed
branch
from
09dba08
to
71c2fa7
Compare
Chocobozzz
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Please add this state in https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/shared/shared-video-miniature/video-miniature.component.ts#L166 and https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/+videos/+video-watch/shared/information/video-alert.component.html
I couldn't find any way to stub or simulate a way to make a transcoding job to fail.
I think we can skip tests here
Chocobozzz
force-pushed
the
feat-4500-tranascoding-failed
branch
2 times, most recently
from
a3b0c52
to
6c68e90
Compare
Chocobozzz
force-pushed
the
feat-4500-tranascoding-failed
branch
from
6c68e90
to
c97c0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a job fails to transcode a video, move it to transcoding failed state.
Related issues
closes #4500
Has this been tested?
I couldn't find any way to stub or simulate a way to make a transcoding job to fail.