Fix crash when a keybinding with a category not known to MC gets added #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client and never see the server, and merge local and server completion suggestions for the client gui.
|
This is the pull request for the LocalCommandAdder interface + supporting Mixins to allow commands be executed on the client thread without ever being sent to the server, and combining client + server commands in the command line GUI suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a KeyBinding gets added that uses a category that's unknown to Minecraft, opening the "Controls" option dialog results in a crash.
This is because KeyBinding.java initializes a map (called CATEGORY_ORDER) from category name to a sorting index, and this map doesn't get updated when the KeyBind is added, resulting in an NPE when the GUI actually tries sorting existing indexes.
This patch fixes this behaviour by providing a Mixin that appends the new category name to the CATEGORY_ORDER map whenever a KeyBind with an yet-unknown name gets added.