Added option to clear complete call log. Closes #61. #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed startup theme bug (hotfix)
|
Thank you very much! apologies for the long wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option to clear all recent calls is added to the 'Settings' menu. I know this isn't the most appropriate place for it but IMO it is the most intuitive.
My proposal for making this better: The fact that tapping on an item from the call log (with 'Group Similar Recents' turned on) brings up a full call log (with recents ungrouped) and not the option to call the number directly is unintuitive. The menu where 'Settings' currently is can be reworked to have three buttons: 'Clear Recents', 'View Complete Call Log' and 'Settings', the third of which opens a new page that shows the settings.
Also, I am aware that there is a bug where, after clearing recents, the 'Are You Sure' menu does not go away by itself. I did not fix this on purpose because the same bug already existed when clearing a single call log and I think the two should be fixed together in a separate issue.