Various fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 21, 2020 16:37
ParthDesai
reviewed
Feb 26, 2020
|
That was unintended. Feel free to remove
…On Wed, 26 Feb 2020, 09:28 Parth, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In x/auth/keeper.go
<#5 (comment)>:
> @@ -18,7 +18,8 @@ import (
// encoding/decoding library.
type AccountKeeper struct {
// The (unexposed) key used to access the store from the Context.
- key sdk.StoreKey
+ key sdk.StoreKey
+ supplyKey sdk.StoreKey
Why was this added?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=ABA7QYGIEFZGCHBEHW2JSLDREYY2LA5CNFSM4K2MYVRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCW6X2LA#pullrequestreview-364739884>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA7QYBFX42SBKKEMCM42MTREYY2LANCNFSM4K2MYVRA>
.
|
ParthDesai
reviewed
Feb 26, 2020
|
Well spotted ;)
…On Wed, 26 Feb 2020, 11:21 Parth, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In x/staking/keeper/slash.go
<#5 (comment)>:
> @@ -217,6 +217,7 @@ func (k Keeper) slashUnbondingDelegation(ctx sdk.Context, unbondingDelegation ty
entry.Balance = entry.Balance.Sub(unbondingSlashAmount)
unbondingDelegation.Entries[i] = entry
k.SetUnbondingDelegation(ctx, unbondingDelegation)
+ k.ExportUnbondingsForAccount(ctx, unbondingDelegation.DelegatorAddress)
We are already exporting at end of function SetUnbondingDelegation
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=ABA7QYFUY4PS7J6ZMIQAIDTREZGFFA5CNFSM4K2MYVRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCW7LGYA#pullrequestreview-364819296>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA7QYCNQ425WTFUNOTVMU3REZGFFANCNFSM4K2MYVRA>
.
|
ParthDesai
reviewed
Feb 26, 2020
joe-bowman
force-pushed
the
various-fixes
branch
from
6f9a20a to
983b940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ChorusOne/hipparchus/issues/27 and https://github.com/ChorusOne/hipparchus/issues/28