Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack overflow in Anker::SendRewards #566

Merged
merged 2 commits into from
May 18, 2022
Merged

Fix stack overflow in Anker::SendRewards #566

merged 2 commits into from
May 18, 2022

Commits on May 12, 2022

  1. Add test for Anker::SendRewards stack overflow 

    We cannot really test this call without the full Wormhole programs and
all of their associated accounts and dependencies in place, which is a
pain. But we can at least test that can get one particular error. I am
hoping that failing to call the Wormhole program will result in a
different error than the "ProgramFailedToComplete" that we get now, and
that we can test for the stack overflow this way.

The new test currently fails.
    @ruuda
    ruuda committed May 12, 2022
    Configuration menu
    Copy the full SHA
    6cfc996 View commit details
    Browse the repository at this point in the history

  2. Fix stack overflow in Anker::SendRewards by boxing 

    Put more things on the heap to free up some stack space. This makes the
test pass, it now fails at trying to call the program, it no longer
overflows the stack.
    @ruuda
    ruuda committed May 12, 2022
    Configuration menu
    Copy the full SHA
    d902957 View commit details
    Browse the repository at this point in the history