-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixup preview rendering and logic of preview key binding being shown in shortcut list #387
Merged
ChrisTitusTech
merged 5 commits into
ChrisTitusTech:main
from
cartercanedy:fixup-preview-rendering
Sep 19, 2024
Merged
fix: Fixup preview rendering and logic of preview key binding being shown in shortcut list #387
ChrisTitusTech
merged 5 commits into
ChrisTitusTech:main
from
cartercanedy:fixup-preview-rendering
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2024
Closed
cartercanedy
changed the title
Fixup preview rendering and logic of preview key binding being shown in shortcut list
fix: Fixup preview rendering and logic of preview key binding being shown in shortcut list
Sep 15, 2024
adamperkowski
approved these changes
Sep 15, 2024
nnyyxxxx
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
7 tasks
6 tasks
6 tasks
Please remove these lines from the code Your implementation is better and these lines are not necessary if this is merged |
ChrisTitusTech
approved these changes
Sep 19, 2024
@ChrisTitusTech please implement the above requested changes before merging |
Thanks to @jeevithakannan2 for idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup rendering of floating text and logc of preview key binding being shown in shortcut list
Type of Change
Description
Any floating content that gets rendered has the possibility of rendering any text from the underlying widget. Prior to drawing the float content, the area that the float content is rendered to should be cleared prior to drawing the float content.
Impact
Having extraneous text present within the preview area might confuse users if the text that is presented from the underlying widget looks like valid bash. This removes the possibility for confusion.
Also, the key binding for showing the preview isn't rendered if the list widget is at the top-level dir of a category, but is properly shown in subdirs. The previewing capability is pretty nifty and should be properly displayed as a key binding when valid.
Issue related to PR
Checklist