Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oosu essential tweak #2099

Merged

Conversation

Marterich
Copy link
Contributor

@Marterich Marterich commented Jun 17, 2024

Resolves: #2085

As explained in the Linked Issue, I think the time has come to remove the OOSU Checkbox from the Essential Tweaks.
The Button under Advanced Tweaks remains, but the wording was changed so that it makes more sense even without the previous simple checkbox tweak.

  • It was unclear to the users what changes were applied by the function which generated lots of Issues regarding disabled functionality.
  • OO Software seems to have included more functionality that users actually want to use in their "recommendations"

For the full reasoning behind this change, please take a look at the Issue. #2085

Prevents issues like this in the future
Closes: #2047
Closes: #2027
Closes: #2012

@og-mrk
Copy link
Contributor

og-mrk commented Jun 23, 2024

The changes look great, and it's quite nice of you to propose the idea first to get feedback from other users and contributers 👍

I guess that the .cfg files in config folder is not needed if this PR gets merged, may be removing those .cfg is worth doing? To remove unused files and drope support for them (still remember that O&O Shutup didn't work for a long time, up until the config files got updated 😅)

It could be removed in a separate PR.. but I don't see why it wouldn't be possible to do it here.. but anyhow, good work as always @Marterich 👍

EDIT: Just noticed that you did remove the .cfg files, my bad for not double checking 😅

@Marterich
Copy link
Contributor Author

Marterich commented Jun 23, 2024

The changes look great, and it's quite nice of you to propose the idea first to get feedback from other users and contributers 👍

I guess that the .cfg files in config folder is not needed if this PR gets merged, may be removing those .cfg is worth doing? To remove unused files and drope support for them (still remember that O&O Shutup didn't work for a long time, up until the config files got updated 😅)

It could be removed in a separate PR.. but I don't see why it wouldn't be possible to do it here.. but anyhow, good work as always @Marterich 👍

If you look real close at the changed files you can see that the files are removed as well 😜
The only thing I didn't remove was the cfg parsing bit in the compile script

@og-mrk
Copy link
Contributor

og-mrk commented Jun 23, 2024

The changes look great, and it's quite nice of you to propose the idea first to get feedback from other users and contributers 👍

I guess that the .cfg files in config folder is not needed if this PR gets merged, may be removing those .cfg is worth doing? To remove unused files and drope support for them (still remember that O&O Shutup didn't work for a long time, up until the config files got updated 😅)

It could be removed in a separate PR.. but I don't see why it wouldn't be possible to do it here.. but anyhow, good work as always @Marterich 👍

If you look real close at the changed files you can see that the files are removed as well 😜
The only thing I didn't remove was the cfg parsing bit in the compile script

Yahh I just noticed that 😂 viewing Git patches in the middle of the night (inside a smartphone) is not the best thing to do 😅

Also the compile bit could be done quite easily (famous last words), I'll make a PR to your Fork, give me a minute while I open my laptop...

EDIT: Made the PR, here's a link to it.

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had some changes to the compile script and I believe this one isn't up to date with that. Can you pull the changes and recommit?

@ChrisTitusTech ChrisTitusTech merged commit de424ce into ChrisTitusTech:main Jun 25, 2024
@4yman-0
Copy link

4yman-0 commented Jun 25, 2024

Niiiiice! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
4 participants