-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove oosu essential tweak #2099
Remove oosu essential tweak #2099
Conversation
The changes look great, and it's quite nice of you to propose the idea first to get feedback from other users and contributers 👍 I guess that the It could be removed in a separate PR.. but I don't see why it wouldn't be possible to do it here.. but anyhow, good work as always @Marterich 👍 EDIT: Just noticed that you did remove the |
If you look real close at the changed files you can see that the files are removed as well 😜 |
Yahh I just noticed that 😂 viewing Git patches in the middle of the night (inside a smartphone) is not the best thing to do 😅 Also the compile bit could be done quite easily (famous last words), I'll make a PR to your Fork, give me a minute while I open my laptop... EDIT: Made the PR, here's a link to it. |
Remove The Entire 'Adding: Config *.cfg' Compilation Process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had some changes to the compile script and I believe this one isn't up to date with that. Can you pull the changes and recommit?
Niiiiice! 🚀 |
Resolves: #2085
As explained in the Linked Issue, I think the time has come to remove the OOSU Checkbox from the Essential Tweaks.
The Button under Advanced Tweaks remains, but the wording was changed so that it makes more sense even without the previous simple checkbox tweak.
For the full reasoning behind this change, please take a look at the Issue. #2085
Prevents issues like this in the future
Closes: #2047
Closes: #2027
Closes: #2012