Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp server to code signature #3139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxi322
Copy link

@maxi322 maxi322 commented Dec 30, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement
  • CI improvement

Description

Add a timestamp signature to the final artifact in order to still have a vaild signature even when the code signing certificate is already expired.

Testing

I have done an offline test with a local selfsigned codesign certificate in order to verify that this actually works with powershell scripts.

Impact

The final released powershell script carries a valid code signature even after the certificate with which it was signed is already expired.

Issue related to PR

  • Resolves -

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants