Skip to content

Conversation

@Pytal
Copy link

@Pytal Pytal commented Apr 6, 2022

Fix CI errors in some dependent packages e.g. nextcloud/files_antivirus#226

2.0.1 seems to be the latest release which still supports PHP 7.3 needed by apps which still support Nextcloud 21

@Pytal
Copy link
Author

Pytal commented Apr 6, 2022

@ChristophWurst look safe to you?

@ChristophWurst
Copy link
Owner

I'd only do this if nextcloud/server locks it as well

@ChristophWurst
Copy link
Owner

Could you pin it for https://github.com/nextcloud/3rdparty/blob/d80ec1fa2dad1c3ede272583e3c4f1f77f40141b/composer.json#L43? If we go to 2.x only here it would be a false claim. Right now 24 still comes with the 1.x version

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the pin-psr-container branch from 5210e3d to 6b08588 Compare April 8, 2022 17:39
@Pytal
Copy link
Author

Pytal commented Apr 8, 2022

Without this change it woud still find the same latest version according to the range as the error in nextcloud/files_antivirus#226 with ^1.0 shows

christophwurst/nextcloud v22.1.1 requires psr/container ^1.0 -> found psr/container[1.0.0, 1.1.0, 1.1.1, 1.1.2]

but I'll change it to ^1.1.1 anyways to match https://github.com/nextcloud/3rdparty/blob/d80ec1fa2dad1c3ede272583e3c4f1f77f40141b/composer.json#L43

@Pytal Pytal changed the title Pin psr/container to 2.0.1 Bump psr/container to ^1.1.1 Apr 8, 2022
@Pytal
Copy link
Author

Pytal commented Apr 8, 2022

So this would not fix the CI error but would make this package match https://github.com/nextcloud/3rdparty/blob/d80ec1fa2dad1c3ede272583e3c4f1f77f40141b/composer.json#L43

@ChristophWurst
Copy link
Owner

I've pushed this manually for master, stable24-stable22. Stable21 still uses 1.0

@ChristophWurst
Copy link
Owner

49190a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants