feat: Inject sentry tracing information for rendered HTML #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
Might need https://docs.sentry.io/platforms/javascript/tracing/trace-propagation/ as a second step |
| @@ -76,6 +76,9 @@ public function boot(IBootContext $context): void { | |||
| 'traces_sample_rate' => $config->getSamplingRate(), | |||
| 'profiles_sample_rate' => $config->getProfilesSamplingRate(), | |||
| ]); | |||
|
|
|||
| \OC_Util::addHeader('meta', ['name' => 'baggage', 'content' => \Sentry\getBaggage()]); | |||
There was a problem hiding this comment.
Yep didn't find a way through the public one, need to think a bit how that could be arranged
There was a problem hiding this comment.
Can we use a global middleware?
There was a problem hiding this comment.
We cannot access the template instance from the template response in the middleware, but I have a local draft for extending that API, will check the next days.
There was a problem hiding this comment.
Seems I won't find time, let me close this until it becomes more relevant again or anyone else wants to pick up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to further trace from page rendering to network requests that are done in javascript.
https://docs.sentry.io/platforms/php/tracing/trace-propagation/custom-instrumentation/#inject-tracing-information-into-rendered-html