Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/oddysey events #50

Merged
merged 6 commits into from
May 24, 2021
Merged

Feat/oddysey events #50

merged 6 commits into from
May 24, 2021

Conversation

Pjiesco
Copy link
Collaborator

@Pjiesco Pjiesco commented May 24, 2021 •
edited
Loading

Added missing events

@Pjiesco
feat(events): SellSuitEvent, SellWeaponEvent, TradeMicroResourcesEven…
85d34e7 
…t, UpgradeSuitEvent, UpgradeWeaponEvent UseConsumableEvent
@Pjiesco
feat(events): CreateSuitLoadoutEvent, DeleteSuitLoadoutEvent, EmbarkE…
3f4bcc7 
…vent, LoadoutEquipModuleEvent, LoadoutRemoveModuleEvent, RenameSuitLoadoutEvent, ScanOrganicEvent, SellMicroResourcesEvent, SellOrganicDataEvent, ShipLockerMaterialsEvent, SwitchSuitLoadoutEvent, TransferMicroResourcesEvent

fix: Wrong data types
@Pjiesco Pjiesco added enhancement New feature or request events Events and Events Data related labels May 24, 2021
@Pjiesco Pjiesco added this to the 1.0.0 milestone May 24, 2021
This was linked to issues May 24, 2021
[Missing Event] SellOrganicData #39
Closed
[Missing Event] SellSuit #40
Closed
[Missing Event] SellWeapon #41
Closed
[Missing Event] ShipLockerMaterials #42
Closed
[Missing Event] SwitchSuitLoadout #43
Closed
[Missing Event] TransferMicroResources #44
Closed
[Missing Event] TradeMicroResources #45
Closed
[Missing Event] UpgradeSuit #46
Closed
[Missing Event] UpgradeWeapon #47
Closed
[Missing Event] UseConsumable #48
Closed
ChristopheCVB
ChristopheCVB requested changes May 24, 2021
View reviewed changes
Copy link
Owner

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost first try! Great job ;)

src/main/java/com/christophecvb/elitedangerous/events/backpack/TransferMicroResourcesEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/backpack/TransferMicroResourcesEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/buysell/SellMicroResourcesEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/buysell/SellOrganicDataEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/buysell/SellSuitEvent.java Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/loadout/LoadoutRemoveModuleEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/other/EmbarkEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/other/EmbarkEvent.java Outdated Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/events/trade/TradeMicroResourcesEvent.java Show resolved Hide resolved
src/main/java/com/christophecvb/elitedangerous/models/OrganicData.java Outdated Show resolved Hide resolved
ChristopheCVB
ChristopheCVB previously approved these changes May 24, 2021
View reviewed changes
@ChristopheCVB ChristopheCVB merged commit 4ce32cd into master May 24, 2021
@ChristopheCVB ChristopheCVB deleted the feat/oddysey_events branch May 24, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheCVB ChristopheCVB ChristopheCVB approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request events Events and Events Data related
Projects
None yet
Milestone
1.0.0
2 participants
@Pjiesco @ChristopheCVB