Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events FleetCarriers #9

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Events FleetCarriers #9

merged 5 commits into from
Oct 14, 2020

Conversation

Pjiesco
Copy link
Collaborator

@Pjiesco Pjiesco commented Oct 14, 2020

No description provided.

ChristopheCVB
ChristopheCVB requested changes Oct 14, 2020
View reviewed changes
Copy link
Owner

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs a bit of refactoring for the CarrierModulePackEvent and CarrierShipPackEvent

...ava/com/github/ChristopheCVB/EliteDangerous/events/fleetcarriers/CarrierModulePackEvent.java Outdated Show resolved Hide resolved
.../java/com/github/ChristopheCVB/EliteDangerous/events/fleetcarriers/CarrierShipPackEvent.java Outdated Show resolved Hide resolved
@ChristopheCVB ChristopheCVB added the events Events and Events Data related label Oct 14, 2020
@ChristopheCVB ChristopheCVB added this to the 1.0.0 milestone Oct 14, 2020
@ChristopheCVB ChristopheCVB changed the title Pjiesco fleetcarrier events Events FleetCarriers Oct 14, 2020
ChristopheCVB
ChristopheCVB approved these changes Oct 14, 2020
View reviewed changes
Copy link
Owner

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopheCVB ChristopheCVB merged commit b864426 into master Oct 14, 2020
@ChristopheCVB ChristopheCVB deleted the pjiesco_events_fleetcarriers branch October 14, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheCVB ChristopheCVB ChristopheCVB approved these changes

Assignees

@Pjiesco Pjiesco

Labels
events Events and Events Data related
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Pjiesco @ChristopheCVB