-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.0.0 #51
Draft
ChristopheCVB
wants to merge
43
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
9.0.0 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add parentGroup field in createState message * bump SDK and TP Api version * Change parameter order * feat: use the name from the category of the categoryId if parentGroup isn't specified * fix: typo's in stateId fix: use correct categoryId * fix: add check for category id from constants * fix: break outer loop * feat: add CategoryHelper.getCategoryShortId method
Waiting for API stabilization |
core: TP_JAVA_FILE
core: Use callbacksExecutor
Closed
Co-authored-by: Christophe Carvalho Vilas-Boas <christophe.carvalhovilasboas@gmail.com>
Co-authored-by: LGTM Migrator <lgtm-migrator@users.noreply.github.com>
Library/src/main/java/com/christophecvb/touchportal/TPInvokable.java
Dismissed
Show dismissed
Hide dismissed
Library/src/main/java/com/christophecvb/touchportal/TouchPortalPlugin.java
Dismissed
Show dismissed
Hide dismissed
* @return Pair<JsonObject, TypeSpec.Builder> dataPair | ||
* @throws GenericHelper.TPTypeException If a used type is not Supported | ||
*/ | ||
public static <T extends Annotation> Pair<JsonObject, TypeSpec.Builder> process(TouchPortalPluginAnnotationsProcessor processor, RoundEnvironment roundEnv, Element pluginElement, Plugin plugin, Element categoryElement, Category category, Element targetElement, T annotation, JsonObject jsonElement, Element dataElement) throws GenericHelper.TPTypeException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'plugin' is never used.
* @throws GenericHelper.TPTypeException If a used type is not Supported | ||
* @throws TPAnnotationException If an Annotation is misused | ||
*/ | ||
public static Pair<JsonObject, TypeSpec.Builder> process(TouchPortalPluginAnnotationsProcessor processor, RoundEnvironment roundEnv, Element pluginElement, Plugin plugin, Element categoryElement, Category category, Element eventElement) throws GenericHelper.TPTypeException, TPAnnotationException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'roundEnv' is never used.
* @throws GenericHelper.TPTypeException If a used type is not Supported | ||
* @throws TPAnnotationException If an Annotation is misused | ||
*/ | ||
public static Pair<JsonObject, TypeSpec.Builder> process(TouchPortalPluginAnnotationsProcessor processor, RoundEnvironment roundEnv, Element pluginElement, Plugin plugin, Element categoryElement, Category category, Element eventElement) throws GenericHelper.TPTypeException, TPAnnotationException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'plugin' is never used.
* @throws GenericHelper.TPTypeException If a used type is not Supported | ||
* @throws TPAnnotationException If an Annotation is misused | ||
*/ | ||
public static Pair<JsonObject, TypeSpec.Builder> process(TouchPortalPluginAnnotationsProcessor processor, RoundEnvironment roundEnv, Element pluginElement, Plugin plugin, Element categoryElement, Category category, Element stateElement) throws GenericHelper.TPTypeException, TPAnnotationException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'roundEnv' is never used.
* @throws GenericHelper.TPTypeException If a used type is not Supported | ||
* @throws TPAnnotationException If an Annotation is misused | ||
*/ | ||
public static Pair<JsonObject, TypeSpec.Builder> process(TouchPortalPluginAnnotationsProcessor processor, RoundEnvironment roundEnv, Element pluginElement, Plugin plugin, Element categoryElement, Category category, Element stateElement) throws GenericHelper.TPTypeException, TPAnnotationException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'plugin' is never used.
* Feat: Setting Tooltip * fix: use java 8 * Remove empty lines * Check if empty * use UpperCamelCase instead of Full uppercase * Check if empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touch Portal Plugin SDK v9.0.0
working with Touch Portal Plugin API v7