fix(global): remove redundant @ from marriage proposal string
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay so I just had a look at #358 and it seems like the @ is intended, let me know if removing the |
|
As discussed with @IamSmeagol, since the |
ayamdobhal
changed the title
@ from getUniqueName@ from marriage proposal string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is intended but the function returns
@along with the already unique username if the user has updated to the new username (no discriminator). This causes the username to be returned as@<username>which turns into@@<username>wherever the message string already has an@before the username. (image attached)Another way to fix this would be to remove
@from the message strings but I believe this is much simpler.