Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for grouping echo commands would be fine #144

Closed
mcmilk opened this issue Jun 27, 2023 · 5 comments · Fixed by #150
Closed

Support for grouping echo commands would be fine #144

mcmilk opened this issue Jun 27, 2023 · 5 comments · Fixed by #150

Comments

@mcmilk
Copy link

mcmilk commented Jun 27, 2023

The runner for arm64, amd64 and ppc64 are working really nice.

Could you add support for the grouping commands?

jobs:
  bash-example:
    runs-on: ubuntu-latest
    steps:
      - name: Group of log lines
        run: |
            echo "::group::My title"
            echo "Inside group"
            echo "::endgroup::"

Reference Link in the documentation: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines

@ChristopherHX
Copy link
Owner

ChristopherHX commented Jun 28, 2023

You get somewhat broken grouping by (The emoji prefix and the group command are part of the placeholder)

jobs:
  bash-example:
    runs-on: ubuntu-latest
    steps:
      - name: Group of log lines
        run: |
            echo "##[group]My title"
            echo "Inside group"
            echo "##[endgroup]"

The actions UI only understand the azure pipelines grouping syntax, the actions/runner translates both types of grouping commands to azure pipelines style while act don't.

BTW: my suggestion will work with both this runner and actions runner.

@mcmilk
Copy link
Author

mcmilk commented Jun 29, 2023

Is it possible to remove the "? ##[group]" in the output?
Is this some debugging which can be turned off?

2023-06-29_091216

@ChristopherHX
Copy link
Owner

Is it possible to remove the "? ##[group]" in the output?

Yes by modifing the act submodules commandhandler and deleting the emoji prefix.
Preferable the emoji prefix of disabled commands shouldbe removed too, nektos/act has way to much emoji stuff in it's logger.

Is this some debugging which can be turned off?

No, the act tool behind uncoditionally emits emoticon prefixes for parsed commands.

@mcmilk
Copy link
Author

mcmilk commented Jun 29, 2023

Ah, thanks for your comments, I will try to dig into these submodules ;-)

@mcmilk mcmilk closed this as completed Jul 1, 2023
@ChristopherHX
Copy link
Owner

I wouldn't close this issue until it works like in actions/runner.

I'm more focused to fix issues caused by protocol updates from GitHub #96. After this actually works this enhancement can be considered by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants