Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming runner-admin / broker / run / results / launch service support #96

Open
7 of 8 tasks
ChristopherHX opened this issue Feb 6, 2023 · 13 comments
Open
7 of 8 tasks

Comments

@ChristopherHX
Copy link
Owner

ChristopherHX commented Feb 6, 2023

Based on GitHub Changelog actions/runner#886 (comment), they aim to make the breaking change on July 31, 2023 end of August / early September timeframe and start to send the new RunnerJobRequest message.

actions/runner protocol changes

github/actions-runner-admin

broker

github/actions-run-service (written in go source)

github/actions-results-service (written in go source(1) and source(2))

launch service (github/actions-dotnet based)

This runner changes

This change could make all current github-act-runner releases unusable and you are forced to update from old releases.

@ChristopherHX ChristopherHX pinned this issue Feb 6, 2023
@ChristopherHX ChristopherHX changed the title Upcoming run service support Upcoming run / results service support Feb 15, 2023
@ChristopherHX ChristopherHX changed the title Upcoming run / results service support Upcoming actions-runner-admin / run / results service support Mar 18, 2023
@ChristopherHX ChristopherHX changed the title Upcoming actions-runner-admin / run / results service support Upcoming runner-admin / run / results service support Mar 18, 2023
@ChristopherHX ChristopherHX changed the title Upcoming runner-admin / run / results service support Upcoming runner-admin / broker / run / results service support Apr 1, 2023
@ChristopherHX ChristopherHX changed the title Upcoming runner-admin / broker / run / results service support Upcoming runner-admin / broker / run / results / launch service support Apr 13, 2023
@ChristopherHX
Copy link
Owner Author

I wonder how I could test the new protocol, until it is live.
Theoretically jobs from RunnerJobRequest can work right now in the main branch, but maybe I made a mistake.

At least with #126 I assume it should work.

@ChristopherHX
Copy link
Owner Author

There has been an update to the timeline of the breaking change: actions/runner#886 (comment)

Thank you all for being patient with us. 🙇🏼‍♂️ As bryanmacfarlane mentioned earlier, we are almost there for this feature, since this involves some pretty significant changes on our end, we are being careful in the process, and we are currently addressing a few scale concerns. We'd like to do some load testings as well. The current ETA for beta testing this feature is end of August / early September timeframe. Again thank you very much for using Actions and being patient while we make these changes.

The next weeks are safe from the coming breaking change.

@ChristopherHX
Copy link
Owner Author

Another update, self-hosted runners can be affected (if that date is actually correct and they don't postpone it again) starting with 12. September 2023 on github.com src: https://github.blog/changelog/2023-08-29-github-actions-review-network-access-settings-for-the-self-hosted-runners/.
At least the changelog entry reads to imply some server change like moving the protocol over to the new backend.

@ChristopherHX
Copy link
Owner Author

⚠️ Release <= v0.6.4 has a bug, which prevents uploading logs via results service.

Partial testing now possible, results receiver endpoint now defined.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Warning github-act-runner may stopped working!, please investigate (resolved)

@nwf-msr
Copy link
Contributor

nwf-msr commented Oct 20, 2023

FWIW, I just ran our snmalloc workflow that uses github-act-runner and things look fine, so that alert may just be a local thing in the regression test.

@ChristopherHX
Copy link
Owner Author

It was an outage of the deb repository used for installing the runner, until now we are still using the good old protocol.
The only thing changed is that the GitHub Actions Services are now powered by .net (core) and Kestrel (a new http header appeared)

@ChristopherHX
Copy link
Owner Author

Status Update

They seem to officially target Q1 2024 for this change now...

Long waiting to be hit by announced backend changes

@ChristopherHX
Copy link
Owner Author

Alert Regression
Public beta of Actions streaming logs with backscroll seem to break live logs.

Logs still appear if the job finished and you refresh the page.

Maybe this runner need to start to also do dual upload of step updates to both old and new backed like the official runner.

@ChristopherHX
Copy link
Owner Author

Release v0.6.8 fixes the live log issue, consider updating to resolve the regression using the beta backend

@ChristopherHX
Copy link
Owner Author

ChristopherHX commented Jun 29, 2024

(Test) Rollout for a breaking service change has been seen in the wild #186

Waiting for beeing affected to implement and test this change in the runner

Resolved in v0.8.0, the next wave is ahead

Copy link

github-actions bot commented Nov 1, 2024

Warning github-act-runner may stopped working!, please investigate

@ChristopherHX
Copy link
Owner Author

False alarm, GitHub removed my 1 year old regression runner registration deliberately.

They should fix their service!, saw a GitHub Issue before

My backup regression voter on private repo still working...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants