start calling run service for job completion #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaananth
commented
Feb 1, 2023
yaananth
commented
Feb 1, 2023
yaananth
commented
Feb 1, 2023
yaananth
commented
Feb 1, 2023
yaananth
commented
Feb 1, 2023
yaananth
commented
Feb 1, 2023
yaananth
commented
Feb 1, 2023
TingluoHuang
reviewed
Feb 1, 2023
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
yaananth
commented
Feb 1, 2023
TingluoHuang
reviewed
Feb 1, 2023
thboop
reviewed
Feb 1, 2023
thboop
reviewed
Feb 1, 2023
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
thboop
reviewed
Feb 1, 2023
…anth/runner into yaananth-run-service-jobcom
thboop
reviewed
Feb 1, 2023
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
8 tasks
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* start calling run service for job completion * cleanup * nit: lines Co-authored-by: Tingluo Huang <tingluohuang@github.com> * clean up * give sanity back to thboop Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> * add clean up back * clean up * clean up more * oops * copied from existing, but :thumb: Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> --------- Co-authored-by: Tingluo Huang <tingluohuang@github.com> Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
* start calling run service for job completion * cleanup * nit: lines Co-authored-by: Tingluo Huang <tingluohuang@github.com> * clean up * give sanity back to thboop Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> * add clean up back * clean up * clean up more * oops * copied from existing, but :thumb: Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> --------- Co-authored-by: Tingluo Huang <tingluohuang@github.com> Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://github.com/github/actions-service-team/issues/3446
This enables runner to call run service directly to complete the job.
There is more work left to send right data for job completion which will be in follow ups. We also need to start streaming events, upload logs etc., , which are all out of scope of this PR.