Job names cannot handle formatting properly with reusable workflow inputs

[KitsuneAlex]

A small cosmetic issue i found regarding the name formatting of jobs.
When i use string interpolation with input properties, it completely breaks down and looks like this:

[KitsuneAlex]

Is it possible that this is caused by an incompatible Node version by any chance?

[ChristopherHX]

Is it possible that this is caused by an incompatible Node version by any chance?

No, it has not been implemented yet. Expression are not evaluated by nodejs, uses nektos/act to do it.

[KitsuneAlex]

Oh, gotcha! ^^ Should i close this for now or just leave it open as it is just a cosmetic issue? :)

[ChristopherHX]

I consider this once I have fun implementing this, until I would keep it open.

[KitsuneAlex]

Sure thing ^^ If you want a helping hand by the way, i'd be happy to help if needed since i really like this runner implementation. I didn't really do much Go before, but i'm an experienced C++ coder and i also got quite comfortable with Rust, so i think i could wrap my head around Go ^^

[ChristopherHX]

If you want a helping hand by the way, i'd be happy to help if needed since i really like this runner implementation

I appreciate anyone who want to contribute. I see we are both from Germany, small world. We can also move this project to a GitHub Organization once it make sense.

Actually I just added a long list of known limitation instead of implementing everything. The protocol has been pretty stable between 2021-2023, the first really breaking change is coming soon #96 and there is still some work to do. The most challenging is missing access to the coming server implementation of the new protocol.

I didn't really do much Go before, but i'm an experienced C++ coder

Similar to you, I never touched golang before recycling nektos/act in 2021 to build a xplat runner. I could have written this in c++, but I have choosen go to reuse existing code for running actions locally and cross compiling is much easier than via c++.

[KitsuneAlex]

Fair enough. And yeah, didn't know from just your name that you're german :D

[KitsuneAlex]

Do you use nektos/act as a library only? Because it looks very incomplete and unusable for platforms other than Ubuntu right now.

[ChristopherHX]

Do you use nektos/act as a library only?

I use my fork of nektos/act and use it to execute the job (skipping the regular workflow management code), some features of this runner depends on changes of my fork.

But I have written the rest of the code so we can get rid of nekos/act.

• The only hard dependency to nektos/act is in this package https://github.com/ChristopherHX/github-act-runner/tree/main/actionsdotnetactcompat
• By implementing this interface

  github-act-runner/actionsrunner/runner.go

  Lines 42 to 48 in 2923f13

  	type RunnerEnvironment interface {
  	BasicLogger
  	ReadJson(fname string, obj interface{}) error
  	WriteJson(fname string, obj interface{}) error
  	Remove(fname string) error
  	ExecWorker(run *RunRunner, wc WorkerContext, jobreq *protocol.AgentJobRequestMessage, src []byte) error
  	}

  you can write your own code to handle job requests and write content to the logging system of GitHub Actions

it looks very incomplete and unusable for platforms other than Ubuntu right now.

Do you know the HostEnvironment toggle -P <label>=-self-hosted? I have backported this to nektos/act. In 2021 it was impossible to use it without docker backend, I changed that on my own. The documentation about this enhancement of act has not been written yet.

For a sample of a custom worker see: https://github.com/ChristopherHX/megascaler/blob/2acc5d494274426efce35d1cf25bbb51167e96f3/main.go#L84C16-L129 (100% free of nektos/act).