Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run service: send more stuff as part of job completed #2423

Merged
merged 9 commits into from
Feb 7, 2023
Merged

Run service: send more stuff as part of job completed #2423

merged 9 commits into from
Feb 7, 2023

Conversation

yaananth
Copy link
Contributor

@yaananth yaananth commented Feb 7, 2023 •
edited
Loading

Closes https://github.com/github/actions-service-team/issues/3446

Goes hand in hand with https://github.com/github/actions-run-service/pull/310

This PR does the following:

  • new WebAPI folder for results service related things
  • Start sending more data as part of job completed
    • We also need steps info, I am piggy-backing on the step telemetry to construct these since display name etc., are PII< added new class

@yaananth yaananth changed the title send more stuff as part of job completed Run service: send more stuff as part of job completed Feb 7, 2023
@yaananth yaananth marked this pull request as ready for review February 7, 2023 16:46
@yaananth yaananth requested a review from a team as a code owner February 7, 2023 16:46
@yaananth yaananth requested a review from TingluoHuang February 7, 2023 17:19
TingluoHuang
TingluoHuang reviewed Feb 7, 2023
View reviewed changes
src/Sdk/RSWebApi/Contracts/CompleteJobRequest.cs Outdated
[DataMember(Name = "stepResults", EmitDefaultValue = false)]
public IList<StepResult> StepResults { get; set; }
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@yaananth yaananth requested a review from TingluoHuang February 7, 2023 19:26
@yaananth yaananth requested a review from TingluoHuang February 7, 2023 19:52
@yaananth @TingluoHuang
nit: line
0b6e71f 
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
@TingluoHuang TingluoHuang enabled auto-merge (squash) February 7, 2023 19:56
@TingluoHuang TingluoHuang merged commit 67356a3 into actions:main Feb 7, 2023
@ChristopherHX ChristopherHX mentioned this pull request Feb 7, 2023
Open
8 tasks
nikola-jokic pushed a commit to nikola-jokic/runner that referenced this pull request May 12, 2023
@yaananth @TingluoHuang @nikola-jokic
Run service: send more stuff as part of job completed (actions#2423)
fc5c740 
* send more stuff as part of job completed

* feedback

* set only once

* feedback

* feedback

* fix test

* feedback

* nit: spacing

* nit: line

Co-authored-by: Tingluo Huang <tingluohuang@github.com>

---------

Co-authored-by: Tingluo Huang <tingluohuang@github.com>
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Aug 14, 2024
@yaananth @TingluoHuang @AdamOlech
Run service: send more stuff as part of job completed (actions#2423)
35ab233 
* send more stuff as part of job completed

* feedback

* set only once

* feedback

* feedback

* fix test

* feedback

* nit: spacing

* nit: line

Co-authored-by: Tingluo Huang <tingluohuang@github.com>

---------

Co-authored-by: Tingluo Huang <tingluohuang@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaananth @TingluoHuang