changes to support specific run service URL #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaananth
force-pushed
the
yaananth-url-callback2
branch
from
aa7bead to
42985d1
Compare
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
yaananth
commented
Sep 27, 2022
TingluoHuang
reviewed
Oct 7, 2022
| var jobMessage = await runServer.GetJobMessageAsync(messageRef.RunnerRequestId, messageQueueLoopTokenSource.Token); | ||
| if (string.IsNullOrEmpty(messageRef.RunServiceUrl)) | ||
| { | ||
| var actionsRunServer = HostContext.CreateService<IActionsRunServer>(); |
There was a problem hiding this comment.
These should be HostContext.GetService<> so the underline object will be reused.
There was a problem hiding this comment.
👌🏼 I didn't do this btw, this was his how it was before 🤷🏻♂️ I added new code doing the same
Do you want me to do a follow up PR with just this change or do we have any other PR's that we can bundle this with?
There was a problem hiding this comment.
maybe just a follow-up PR for this change only.
8 tasks
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* changes to support run service url * feedback
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
* changes to support run service url * feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/github/c2c-actions-service/issues/3231
Please see the list of all PR's involved and diagram showing before & after on high level and demo video at https://github.com/github/c2c-actions-service/issues/3231#issuecomment-1258397487
TL;DR: Run stamp will inject a run service URL as part of job message, which the broker would send that through to runner.
Runner would directly call the stamp to acquire job (no more proxying through actions service), so changes were needed to support that.
We didn't want to use vssf for the new call, so did the minimum to support the new calls, mimicking vssf but with out vssf based dependencies