feat: report console issues in list_console_messages #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

OrKoN merged 17 commits into main from add-issues-export

Nov 17, 2025

Collaborator

nattallius commented Oct 31, 2025

No description provided.

OrKoN reviewed

View reviewed changes

test.txt Outdated Show resolved Hide resolved

OrKoN changed the title ~~Add issues export~~ feat: export console issues

OrKoN reviewed

View reviewed changes

scripts/post-build.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/issue-descriptions.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

Collaborator

OrKoN commented Nov 6, 2025

There are conflicts with the main branch. Could you please rebase?

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

nattallius force-pushed the add-issues-export branch 2 times, most recently from 9665ceb to 0a00958 Compare

November 11, 2025 12:46

nattallius requested a review from OrKoN

November 11, 2025 12:47

OrKoN reviewed

View reviewed changes

Collaborator

OrKoN left a comment

Thanks! let's also add tests to make sure everything is working end-to-end and please address the lint and formatting issues.

src/PageCollector.ts Outdated Show resolved Hide resolved

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN force-pushed the add-issues-export branch from f964f7b to 7fef676 Compare

November 14, 2025 09:07

nattallius force-pushed the add-issues-export branch from 7fef676 to 0aa6659 Compare

November 14, 2025 09:09

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/McpResponse.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/McpResponse.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/formatters/consoleFormatter.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/McpResponse.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/McpResponse.ts Show resolved Hide resolved

Collaborator

OrKoN commented Nov 14, 2025

Thanks! let's also add tests to make sure everything is working end-to-end and please address the lint and formatting issues.

I think we still need a e2e test similar to tests in tests/McpContext.test.ts in which we use Puppeteer to actually navigate to a page that has an issue. We can pick an issue that is easy to trigger via page.setContent().

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

src/PageCollector.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

tests/PageCollector.test.ts Outdated Show resolved Hide resolved

OrKoN reviewed

View reviewed changes

tests/PageCollector.test.ts Outdated Show resolved Hide resolved

Natallia Harshunova and others added 17 commits

November 17, 2025 10:34


          Subscribe for Audits.issueAdded event

3ec2e33


          Add filtering

d22ef61


          Emit aggregated issue

fbb64e4


          Use import.meta.dirname instead of process.cwd()

0b8257f


          Create console Collector and extract issues subscription logic there

8850deb


          Rebase plus comments fix

89017ac


          Comments fix


          Add newline at the end of the file

a07d59e


          Emit Aggregated issue only for the first time

9f4fa29


          Add tests for console collector, checks issues subscription

15e18bb


          Add formatting

c5bb06b


          Update docs

176acfc


          Remove docs formatting

0a89dbc


          Fix comments

f83eeb2


          remove arguments from issues messages

ad1c5e7

Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>


          Address comments

3d955d6


          remove await

51e1d9b

OrKoN force-pushed the add-issues-export branch from 5480ba1 to 51e1d9b Compare

November 17, 2025 09:34

nattallius changed the title ~~feat: export console issues~~ feat: report console issue in list_console_messages

OrKoN changed the title ~~feat: report console issue in list_console_messages~~ feat: report console issues in list_console_messages

OrKoN approved these changes

View reviewed changes

Collaborator

OrKoN commented Nov 17, 2025

LGTM thanks!

OrKoN enabled auto-merge (squash)

November 17, 2025 09:37

OrKoN merged commit c1e4118 into main

22 checks passed

OrKoN deleted the add-issues-export branch

November 17, 2025 09:38

browser-automation-bot mentioned this pull request

chore(main): release chrome-devtools-mcp 0.11.0 #542

Open

OrKoN mentioned this pull request

refactor: simplify issue management #564

Merged

OrKoN added a commit that referenced this pull request


          refactor: simplify issue management (#564)

3b016f1

follow-up for
#505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet