Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix - Scroll to Search Navigation Bar Visibility Fix #1076

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

4shutosh
Copy link
Contributor

📄 Context

Issue - Search for something on the response page, the search results are visible along with the nav bar, but when we append something to the query, that leads to zero search results, highlighting is reset, but the nav bar with old search results is still visible.

📎 Related PR

#988

🛠️ How to test

  • Search for a word available on the response page, and append something making it a query that won't have any results. the nav bar and the highlighted results should be reset.

@4shutosh 4shutosh requested a review from a team as a code owner July 13, 2023 11:18
@cortinico
Copy link
Member

but the nav bar with old search results is still visible.

Do you have a gif or a video of this bug?

@4shutosh
Copy link
Contributor Author

4shutosh commented Jul 14, 2023

Yes, this is the gif for the bug behaviour.

This is from the develop branch
ezgif com-resize

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cortinico cortinico added this to the 4.1.0 milestone Jul 14, 2023
@cortinico cortinico merged commit 99ab476 into ChuckerTeam:main Jul 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants