-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTP Archive (HAR) #417
Conversation
β¦p to the same value.
I was finally able to sit and test your PR.
Both issues happen for list of transactions and for a single exported transaction. Going to do a code review shortly. |
Thanks for taking a look.
Let me know if there's anything else I can do. |
library/src/main/java/com/chuckerteam/chucker/internal/data/har/Entry.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/data/har/Entry.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/data/har/Har.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/data/har/Request.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/data/har/Request.kt
Outdated
Show resolved
Hide resolved
library/src/test/java/com/chuckerteam/chucker/internal/data/har/HarTest.kt
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/support/FileShareHelper.kt
Outdated
Show resolved
Hide resolved
library/src/test/java/com/chuckerteam/chucker/internal/data/har/HarTest.kt
Outdated
Show resolved
Hide resolved
library/src/test/java/com/chuckerteam/chucker/internal/data/har/HarTest.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/support/JsonConverter.kt
Outdated
Show resolved
Hide resolved
Thanks for taking the time to work on this π |
@cortinico I think I've addressed all PR feedback, and fixed merge conflicts. Please give this another round of review when you get the chance. |
Mentioning this because the conversation about desugaring got resolved. Please see my comment - #417 (comment). |
This reverts commit 5042a28.
@JayNewstrom My main concern with these issues I showed on screenshots is about value of such |
To piggyback on this: is there a tool where we can import the generated .har file? |
Response codes are being saved/displayed in Charles. They're just not displayed in the overview page (which is likely just a Charles bug)
For complex network interactions that are hard to recreate, Charles can be a life saver when trying to recreate. It also has features such as map local, which allows you to use the responses from a session like this instead of hitting a real server. Our team has used this approach for a long time, and it's worked well for us.
There are a lot of tools that can import it, here's another one I've used to test:
I absolutely agree, and I'm willing to be the one that does this! I think there's likely other bugs, and other programs that will have trouble importing for other various reasons, so I didn't expect this to be a one shot and done. |
I've got some extra time this week if there's something I can do to continue to move this along. |
Can you provide a short status update @JayNewstrom ? I'd love to eventually pick this up or have a note if another contributor wants to work on this. |
The current state is working. Although my previous comments still hold, meaning it's working for a very specific set of use cases. Things like binary request/responses, data missing from the database, etc. My biggest reason for closing this is I no longer work on the project that was intended to use this, and my branch has gotten quite out of date. If there's anything else I can do to help going forward, let me know. |
π· Screenshots
π Context
This allows Chucker to share/export files with desktop http viewers such as Charles Proxy, Chrome Network Debugger, etc.
See #401
π« Breaking
No breaking changes.
π οΈ How to test
I added some automated tests. You can also test via the UI (see screenshots). After you have the file ready to import into another application, it should be able to be imported.
β±οΈ Next steps
This handles the simple case, and allows you to view request/response in Charles. The generated file is likely not 100% accurate/to spec yet. See comments in #401 for some reasons why (ie. missing data).
I'd like to ensure this is the right direction, and get bugs/examples that fail to import and fix them as we find them.
I'd also like to add support for binary request/response bodies via base 64 encoding.