-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a shortcut when creating ChuckerInterceptor
#588
Conversation
It seems api test failed, how can I solve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems api test failed, how can I solve it.
By making function you added internal or by executing apiDump
Gradle task.
library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt
Outdated
Show resolved
Hide resolved
I am curios if we need this feature before proceeding with the reviw. |
Personally I like it. I won't fight for it, but I see it as a useful thing. |
library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment, but other than that, LGTM. 🚀
Thank you for this contribution! I'll wait with merging for a second review/opinion.
You'll also need to execute apiDump
Gradle task because a public function was added to the builder.
I think this is a nice addition 👍 |
I will take care of it in a follow-up PR for this feature. |
ChuckerInterceptor
for launchMainActivity
likeLeakCanary