Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set FLAG_IMMUTABLE for error screen PendingIntent #653

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

cortinico
Copy link
Member

📄 Context

Originally reported here #634 (comment)
When we backported this PR #593, the PendingIntent for the error screen slipped through. Therefore users

📝 Changes

Just adding the FLAG_IMMUTABLE to the only PendingIntent that was missing it.

📎 Related PR

#593 and #637

🛠️ How to test

I haven't tested this, it's a best guess fix.

⏱️ Next steps

We should potentially release 3.5.1 with this fix included. Wdyt @vbuberen @MiSikora

@vbuberen
Copy link
Collaborator

Right, we forgot to add flag for this intent because in develop we already removed errors tab and I missed it during cherrypicking.
We would need a hotfix release.

@cortinico cortinico merged commit a9407e3 into 3.x Jul 16, 2021
@cortinico cortinico deleted the nc/flag_immutable branch July 16, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants