Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade logging #4533

Merged
merged 7 commits into from
Nov 27, 2018
Merged

Add upgrade logging #4533

merged 7 commits into from
Nov 27, 2018

Conversation

crossan007
Copy link
Contributor

@crossan007 crossan007 commented Nov 27, 2018

What's this PR do?

adds logging to the upgrade process, and removes a potentially problematic call to ini_set('max_execution_time', 60);

Sample upgrade log
2018-11-27-app.log

@crossan007 crossan007 requested a review from DawoudIO as a code owner November 27, 2018 02:30
@ghost ghost assigned crossan007 Nov 27, 2018
@ghost ghost added the In Review label Nov 27, 2018
@@ -478,21 +487,34 @@ public function moveDir($src, $dest)

public function doUpgrade($zipFilename, $sha1)
{
ini_set('max_execution_time', 60);
Copy link
Contributor Author

@crossan007 crossan007 Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a system task for this that warns if it's below 120 seconds, so this line could prevent an otherwise successful upgrade.

@crossan007 crossan007 added this to the 3.0.12 milestone Nov 27, 2018
@crossan007 crossan007 requested a review from MrClever November 27, 2018 02:42
@ghost ghost assigned DawoudIO Nov 27, 2018
@DawoudIO
Copy link
Contributor

i see the logs

[2018-11-27 13:24:24] defaultLogger.INFO: Starting background job processing [] []
[2018-11-27 13:24:24] defaultLogger.INFO: Not starting application integrity check.  Last application integrity check run: 20181127-132356 [] []
[2018-11-27 13:24:31] defaultLogger.INFO: Downloading release from: https://github.com/ChurchCRM/CRM/releases/download/3.0.11/ChurchCRM-3.0.11.zip to: /home/ubuntu/workspace/src/Upgrade/ChurchCRM-3.0.11.zip [] []
[2018-11-27 13:24:33] defaultLogger.INFO: Finished downloading file.  Execution time: 1576.99 ms [] []
[2018-11-27 13:24:33] defaultLogger.INFO: SHA1 hash for /home/ubuntu/workspace/src/Upgrade/ChurchCRM-3.0.11.zip: 2e76b0078b4e92647ac397b998f5d9da287dd0d8 [] []
[2018-11-27 13:24:33] defaultLogger.INFO: Release notes: *Features* - Improved Admin/Debug page (#4501)  *Bug Fix* - Fixed modal dialog appearing after search query (#4525)  *Inner Beauty* - Add links to a GitHub wiki page for prerequisite failures (#4501) - use Locale-aware system settings to format wedding anniversary and birth date in PDF Confirm report (#4477)    Github Changes: https://github.com/ChurchCRM/CRM/milestone/89?closed=1 See full change log here: https://github.com/ChurchCRM/CRM/blob/master/CHANGELOG.md  SHA1:  2e76b0078b4e92647ac397b998f5d9da287dd0d8  [] []
[2018-11-27 13:24:34] defaultLogger.INFO: Beginnging upgrade process [] []
[2018-11-27 13:24:34] defaultLogger.INFO: PHP max_execution_time is now: 30 [] []
[2018-11-27 13:24:34] defaultLogger.INFO: Beginning hash validation on /home/ubuntu/workspace/src/Upgrade/ChurchCRM-3.0.11.zip [] []
[2018-11-27 13:24:35] defaultLogger.INFO: Hash validation succeeded on /home/ubuntu/workspace/src/Upgrade/ChurchCRM-3.0.11.zip Got: 2e76b0078b4e92647ac397b998f5d9da287dd0d8 [] []
[2018-11-27 13:24:35] defaultLogger.INFO: Extracting /home/ubuntu/workspace/src/Upgrade/ChurchCRM-3.0.11.zip to: /home/ubuntu/workspace/src/Upgrade [] []
[2018-11-27 13:24:36] defaultLogger.INFO: Extraction completed.  Took:1686.54 [] []
[2018-11-27 13:24:36] defaultLogger.INFO: Moving extracted zip into place [] []
[2018-11-27 13:24:37] defaultLogger.INFO: Move completed.  Took:799.18 [] []

@DawoudIO DawoudIO merged commit 049005c into master Nov 27, 2018
@ghost ghost removed the In Review label Nov 27, 2018
@DawoudIO DawoudIO deleted the add-upgrade-logging branch November 27, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants