Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix potentially-undefined fn apache_get_modules, only allow upgrade when logged in, fix kiosk routes, misc minor cleanup #6627

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

DAcodedBEAT
Copy link
Contributor

@DAcodedBEAT DAcodedBEAT commented Nov 6, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Issue ticket number and link

If anyone is experiencing #6621, feel free to test this.
Closes #6628

Screenshots (if appropriate)

N/A

How should this be manually tested?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…w upgrade when logged in, misc minor cleanup
@DAcodedBEAT DAcodedBEAT requested a review from DawoudIO November 6, 2023 18:14
@DAcodedBEAT DAcodedBEAT changed the title attempt to fix potentially undefined fn apache_get_modules, only allow upgrade when logged in, misc minor cleanup attempt to fix potentially-undefined fn apache_get_modules, only allow upgrade when logged in, fix kiosk routes, misc minor cleanup Nov 6, 2023
@DawoudIO DawoudIO added this to the 5.1.1 milestone Nov 6, 2023
@DawoudIO DawoudIO added the bug label Nov 6, 2023
@DawoudIO DawoudIO merged commit 39fafec into master Nov 6, 2023
@DawoudIO DawoudIO deleted the fixes branch November 6, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiosk Manager / Kiosk page
2 participants