Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more null checks when determining age of person #6860

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

DAcodedBEAT
Copy link
Contributor

Description & Issue number it closes

Issue reported from Github. Now that users can be submitted without birth year, a null check must be performed when age is being determined.

Closes #6847

Screenshots (if appropriate)

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DAcodedBEAT DAcodedBEAT added bug Feature: Users php Pull requests that update Php code labels Feb 11, 2024
@DawoudIO DawoudIO merged commit fafcaa2 into master Feb 11, 2024
4 checks passed
@DawoudIO DawoudIO deleted the age-birth-year-null-checks branch February 11, 2024 07:16
@DAcodedBEAT DAcodedBEAT added this to the vNext milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Users php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: About display ages
2 participants