Add overload method to enable CloudWatch Sink through config file.

[gscx233]

ReadFrom.AppSettings() can only accept string input. So add a overload method to accept string params.

[wparad]

We should add in a unit test, as well as better document the use case.

I want to make sure we handle the general use case, this seems like a specific use of a configuration file, and there is another ticket which asks for something similar. We should make sure any change we do here will encourage a solution to the other one. (Although I'm not looking for solving #28 immediately)

Can you add to the PR conversation your configuration file as well as the code you are looking to execute, so that we can discuss what the best way to accomplish this is?

[wparad]

This forces an implementation of a IAmazonCloudWatchLogs client, which shouldn't be newed up here.

[wparad]

Please use a class to contain all the options we care about passing in, the way this currently is does not make it scalable.

[gscx233]

The config file is mostly the same as #28 :

<appSettings>    
    <add key="serilog:minimum-level" value="Verbose" />
    <add key="serilog:using:AmazonCloudWatch" value="Serilog.Sinks.AwsCloudWatch" />
    <add key="serilog:write-to:AmazonCloudWatch.logGroupName" value="***" />
    <add key="serilog:write-to:AmazonCloudWatch.accessKey" value="***" />
    <add key="serilog:write-to:AmazonCloudWatch.secretKey" value="***" />
    <add key="serilog:write-to:AmazonCloudWatch.region" value="us-east-1" />
</appSettings>

And the code is:

Log.Logger = new LoggerConfiguration()
                .ReadFrom.AppSettings()
                .CreateLogger();

[wparad]

I may be missing something but could you help me figure out how using this method would allow setting the LogEventRenderer as part of the CloudWatchOptions configuration. This is an important feature we are offering, and it isn't clear from the Serilog documentation on how to do this. (I ask because the constructor we currently have wouldn't support this as is, and I don't want to diverge from the functionality that is currently being provided by the other constructor).

[wparad]

Is this relevant? serilog/serilog-settings-configuration#53

[gscx233]

Closed because another PR #32 covered this.