Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel runtime. #7

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Fix babel runtime. #7

merged 1 commit into from
Jan 11, 2019

Conversation

wparad
Copy link
Contributor

@wparad wparad commented Jan 11, 2019

For some reason the Regenerator-runtime was included in the deployment of this package. Since we use babel as well, this is broken (I assume it is broken for all users which use babel). The right way to do this is to only include the modules which are necessary. I've updated the configuration to the recommendation, see babel-plugin-transform-runtime for details.

The error displayed was related to babel issue
and was exactly this:
image

@istanishev
Copy link
Contributor

Thanks @wparad! We are using this package in multiple projects together with babel and we haven't noticed a blocking issue. Could you please share what was the error you saw?

@istanishev istanishev merged commit c1df64e into Cimpress:master Jan 11, 2019
@wparad
Copy link
Contributor Author

wparad commented Jan 11, 2019

Thanks @wparad! We are using this package in multiple projects together with babel and we haven't noticed a blocking issue. Could you please share what was the error you saw?

I've updated the description with the original error that shows up in the console. The reason is because babel inserts an require('regenerator-runtime') but doesn't package it (you aren't allow to package that) and apps aren't supposed to install that package either, so it's null.

@wparad wparad deleted the fix-babel-runtime branch January 11, 2019 20:49
@wparad wparad mentioned this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants