Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fastembed as a local embedding vendor #12

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Enable fastembed as a local embedding vendor #12

merged 9 commits into from
Apr 8, 2024

Conversation

trducng
Copy link
Contributor

@trducng trducng commented Apr 6, 2024

No description provided.

@trducng trducng requested review from taprosoft and lone17 April 6, 2024 22:33
Copy link
Contributor

@lone17 lone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a minor concern on the embeddings batch size.

@lone17 lone17 merged commit e75354d into main Apr 8, 2024
3 checks passed
@lone17 lone17 deleted the fastembed branch April 8, 2024 18:44
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
* Prepend all Langchain-based embeddings with LC

* Provide vanilla OpenAI embeddings

* Add test for AzureOpenAIEmbeddings and OpenAIEmbeddings

* Incorporate fastembed

---------

Co-authored-by: ian_Cin <ian@cinnamon.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants