-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[semver:major] ECS Orb 2.0 Update #118
Conversation
…e to puthon script and escaped EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work splitting up the orb.yml.hbs
file into scripts with circleci orb pack
! It's much more maintainable now 🎉 I left some comments for your consideration
@KyleTryon Great work getting to green and thanks for looking into my feedback! Do you think it's feasible to retain running the python unit tests? |
Tests re-added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - it's a pretty beefy PR, so I would love a second pair of eyes on it, but going to go ahead and approve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and I see that the tests are passing 👍
Changes:
src/scripts
directory$AWS_SECRET_ACCESS_KEY
->AWS_SECRET_ACCESS_KEY
$
at the beginning of the environment variables #9launch-type
parameter is now an enum, which accepts a blank string as one of the valuescapacity-provider-strategy
parametercapacity-provider-strategy
is specified, thelaunch-type
parameter must be set to an empty string.capacity-provider-strategy
parameter, enabling the task to run on Fargate SPOT