Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: terraform force delete #178

Merged
merged 2 commits into from
Aug 11, 2022
Merged

fix: terraform force delete #178

merged 2 commits into from
Aug 11, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 11, 2022

The latest aws provider version disabled automatic force delete of aws ecr repositories when running terraform destroy. This PR addresses that issue by applying force_delete = true to the aws_ecr_repository resource.

Jaryt
Jaryt approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brivu brivu merged commit 06a608e into master Aug 11, 2022
@brivu brivu deleted the terraform-force-delete branch August 11, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brivu @Jaryt