Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oidc implementation #184

Merged
merged 18 commits into from
Sep 1, 2022
Merged

feat: oidc implementation #184

merged 18 commits into from
Sep 1, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 31, 2022

This PR makes use of CircleCI's OIDC Token to generate temporary AWS keys, enabling users to run ecs jobs more securely without having to store static keys as environment variables.

To generate temporary tokens, provide the job with a role-arn and role-session-name.

Jaryt
Jaryt reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just those two description changes needed

src/commands/update-service.yml Outdated Show resolved Hide resolved
src/jobs/deploy-service-update.yml Outdated Show resolved Hide resolved
Jaryt
Jaryt approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@brivu brivu merged commit daa548c into master Sep 1, 2022
@brivu brivu deleted the implement-oidc branch September 1, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brivu @Jaryt