Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!:orb tools 12 migration #199

Merged
merged 19 commits into from
May 31, 2023
Merged

Conversation

brivu
Copy link
Contributor

@brivu brivu commented May 30, 2023

Description

This major release updates the AWS ECS Orb to the new major version of Orb Tools. As it contains breaking changes, several modifications were unnecessary to move from v11 to v12.

Changes

  1. All parameters and commands containing dashes have been converted to the new snake case standard (replace - with _).
  2. The comprehensive list of changes can be found below.

Changes in .circleci/config.yml:

  1. Update the orb-tools version from 11.6 to 12.0.
  2. Move the job requirement list from orb-tools/publish to orb-tools/continue.
  3. Remove the orb-tools/publish job since development versions are no longer necessary.
  4. Add the new orb_name parameter in orb-tools/continue.
  5. Rename the orb-tools/continue job parameters to comply with the new snake case standard.
    • orb_name, pipeline_number and vcs_type.

Changes in .circleci/test-deploy.yml:

  1. Update the orb-tools version from 11.6 to 12.0.
  2. Remove the aws-cli: circleci/aws-cli@dev:<<pipeline.git.revision>> line, and replace it with aws-cli: {}.
  3. Remove the orb-tools/lint, orb-tools/pack, and orb-tools/review jobs. ⚠️
  4. Rename the orb-tools/publish job parameters to comply with the new snake case standard.
    • orb_name, vcs_type, pub_type, enable_pr_comment and github_token.
  5. Change the orb-tools/pack filter to trigger only on tagged releases.

@brivu brivu requested a review from a team as a code owner May 30, 2023 22:29
Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either in this PR or another, it looks like parameter names need to be standardized

@brivu brivu merged commit 59cea45 into master May 31, 2023
@brivu brivu deleted the refactor/orb-tools-12-migration branch May 31, 2023 15:42
@brivu brivu self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants