Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rule_name to be optional and add validation in case is not set… #217

Merged
merged 2 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jobs/update_task_definition.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ parameters:
default: false
rule_name:
description: The name of the scheduled task's rule to update. Must be a valid ECS Rule.
default: ""
type: string
auth:
description: |
Expand Down
5 changes: 5 additions & 0 deletions src/scripts/deploy_ecs_scheduled_task.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ fi

ORB_STR_RULE_NAME="$(circleci env subst "${ORB_STR_RULE_NAME}")"

if [[ -n $ORB_STR_RULE_NAME ]]; then
echo "To deploy with an scheduled task, you must provide a rule name"
exit 1
fi

CLI_OUTPUT_FILE=$(mktemp cli-output.json.XXXX)
CLI_INPUT_FILE=$(mktemp cli-input.json.XXXX)

Expand Down