chore: disable golang telemetry #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-roo
reviewed
Aug 19, 2024
| ENV PATH="$GOPATH/bin:/usr/local/go/bin:$PATH" | ||
|
|
||
| # disable telemetry (in a version-independent way) | ||
| go run golang.org/x/telemetry/cmd/gotelemetry@latest off |
There was a problem hiding this comment.
Suggested change
| go run golang.org/x/telemetry/cmd/gotelemetry@latest off | |
| RUN go run golang.org/x/telemetry/cmd/gotelemetry@latest off |
There was a problem hiding this comment.
Saw this PR would unblock the release (if I understand the CI result on the release PR).
Thanks for looking into getting cimg-go:1.23.0 released!
|
this change (even when the syntax is correct 😂 ) does not fix the underlying problem with the multi-arch build. There's now a tracking issue on the go repo here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our official CircleCI Docker Convenience Image support policy, please see CircleCI docs.
This policy outlines the release, update, and deprecation policy for CircleCI Docker Convenience Images.
Description
Disable golang telemetry collection in preparation to release
cimg/go:1.23Reasons
Please provide reasoning for these changes and how this PR achieves them.
If applicable, include a link to the related GitHub issue that this PR will close.
Checklist
Please check through the following before opening your PR. Thank you!
Dockerfile.templatefile only