refactor: Removed the singleton pattern

CircleCI-Public · Aug 8, 2023 · 2f88190 · 2f88190
1 parent 7408eb6
commit 2f88190
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/api/orb/client.go b/api/orb/client.go
@@ -4,20 +4,13 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"sync"
 
 	"github.com/CircleCI-Public/circleci-cli/api"
 	"github.com/CircleCI-Public/circleci-cli/api/graphql"
 	"github.com/CircleCI-Public/circleci-cli/settings"
 	"github.com/pkg/errors"
 )
 
-var (
-	once        sync.Once
-	client      Client
-	clientError error
-)
-
 type clientVersion string
 
 // ConfigResponse is a structure that matches the result of the GQL
@@ -33,15 +26,7 @@ type Client interface {
 	OrbQuery(configPath string, ownerId string) (*api.ConfigResponse, error)
 }
 
-func GetClient(config *settings.Config) (Client, error) {
-	once.Do(func() {
-		client, clientError = newClient(config)
-	})
-
-	return client, clientError
-}
-
-func newClient(config *settings.Config) (Client, error) {
+func NewClient(config *settings.Config) (Client, error) {
 	gql := graphql.NewClient(config.HTTPClient, config.Host, config.Endpoint, config.Token, config.Debug)
 
 	clientVersion, err := detectClientVersion(gql)

diff --git a/cmd/orb.go b/cmd/orb.go
@@ -733,7 +733,7 @@ func validateOrb(opts orbOptions, org orbOrgOptions) error {
 		return fmt.Errorf("failed to get the appropriate org-id: %s", err.Error())
 	}
 
-	client, err := orb.GetClient(opts.cfg)
+	client, err := orb.NewClient(opts.cfg)
 	if err != nil {
 		return errors.Wrap(err, "Getting orb client")
 	}
@@ -759,7 +759,7 @@ func processOrb(opts orbOptions, org orbOrgOptions) error {
 		return fmt.Errorf("failed to get the appropriate org-id: %s", err.Error())
 	}
 
-	client, err := orb.GetClient(opts.cfg)
+	client, err := orb.NewClient(opts.cfg)
 	if err != nil {
 		return errors.Wrap(err, "Getting orb client")
 	}