Skip to content

Commit

Permalink
Ext 358 pr template (#708)
Browse files Browse the repository at this point in the history
* Test

* revert

* Adding PR template to CLI

* Moved file out of folder as many online sources state that this could be why this file is not working
Added to the template with our standard categories
  • Loading branch information
corinnesollows authored May 18, 2022
1 parent 60f56cc commit af626c3
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 13 deletions.
49 changes: 49 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Checklist
=========

- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have checked for similar issues and haven't found anything relevant.
- [ ] This is not a security issue (which should be reported here: https://circleci.com/security/)
- [ ] I have read [Contribution Guidelines](https://github.com/CircleCI-Public/circleci-cli/blob/master/CONTRIBUTING.md).

## Changes
=======

- Put itemized changes here, preferably in imperative mood, i.e. "Add
`functionA` to `fileB`"

## Rationale
=========

What was the overarching product goal of this PR as well as any pertinent
history of changes

## Considerations
==============

Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious

## Analytics Events Added
======================

- `event-name`

## Screenshots
============
<h4>Before</h4>
Image or [gif](https://giphy.com/apps/giphycapture)

<h4>After</h4>
Image or gif where change can be clearly seen

## **Here are some helpful tips you can follow when submitting a pull request:**

1. Fork [the repository](https://github.com/CircleCI-Public/circleci-cli) and create your branch from `master`.
2. Run `make build` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`make test`).
5. The `--debug` flag is often helpful for debugging HTTP client requests and responses.
6. Format your code with [gofmt](https://golang.org/cmd/gofmt/).
7. Make sure your code lints (`make lint`). Note: This requires Docker to run inside a local job.
13 changes: 0 additions & 13 deletions .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST.md

This file was deleted.

0 comments on commit af626c3

Please sign in to comment.