Skip to content

Commit

Permalink
Converts the map from [string]string to [string]interface{} to allow …
Browse files Browse the repository at this point in the history
…for integer and bool values
  • Loading branch information
elliotforbes committed Mar 31, 2023
1 parent 2766f0e commit deec041
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion config/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ func (c *ConfigCompiler) getOrgID(
optsOrgSlug string,
) (string, error) {
if optsOrgID == "" && optsOrgSlug == "" {
fmt.Println("No org id or slug has been provided")
return "", nil
}

Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ type CompileConfigRequest struct {
type Options struct {
OwnerID string `json:"owner_id,omitempty"`
PipelineParameters map[string]interface{} `json:"pipeline_parameters,omitempty"`
PipelineValues map[string]string `json:"pipeline_values,omitempty"`
PipelineValues map[string]interface{} `json:"pipeline_values,omitempty"`
}

// ConfigQuery - attempts to compile or validate a given config file with the
Expand Down
6 changes: 3 additions & 3 deletions config/pipeline.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
)

// CircleCI provides various `<< pipeline.x >>` values to be used in your config, but sometimes we need to fabricate those values when validating config.
type Values map[string]string
type Values map[string]interface{}

// Static typing is bypassed using an empty interface here due to pipeline parameters supporting multiple types.
type Parameters map[string]interface{}
Expand All @@ -31,9 +31,9 @@ func LocalPipelineValues() Values {
}
}

vals := map[string]string{
vals := map[string]interface{}{
"id": "00000000-0000-0000-0000-000000000001",
"number": "1",
"number": 1,
"project.git_url": gitUrl,
"project.type": projectType,
"git.tag": git.Tag(),
Expand Down

0 comments on commit deec041

Please sign in to comment.