Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output breaks on narrow terminals #797

Closed
marcusirgens opened this issue Oct 8, 2022 · 3 comments
Closed

Output breaks on narrow terminals #797

marcusirgens opened this issue Oct 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@marcusirgens
Copy link

marcusirgens commented Oct 8, 2022

Meta:

CircleCI CLI Version:

0.1.22100+a77d125 (homebrew)

Operating System:

macOS 12.5.1 (21G83)

CircleCI CLI Diagnostic:

n/a

Current behavior:

The output of the circleci command appears to be broken in my terminal whenever the window width is below 122 characters, due to the border effect that has been added:
Screenshot 2022-10-08 at 13 15 21

Expected behavior:

The border effect shouldn't break the output. There's only 1 line that "overflows" inside of the box area between 85 and 121 character output width (the --host help text). I would rather have that one line overflowing than every single line on the screen.

Possible solutions:

  • Don't draw this border at all.
  • Disable the border if the window size is smaller than the bounding box size
  • Allow me to disable the border

I don't want to spark a debate around "what is a reasonable window size", but I'm sure most developers don't always run their terminals in full-width or full-screen modes, and breaking output for aesthetic purposes seems like a tradeoff with more negative sides than positive ones?

When did this begin / Was this previously working?:

This seems to have been introduced in #782.

Additional Information:

@marcusirgens marcusirgens added the bug Something isn't working label Oct 8, 2022
@adamdmharvey
Copy link
Contributor

adamdmharvey commented Oct 27, 2022

Whole heartedly agree with this one: the outline makes the CLI extremely hard to use. (Have a MacBook Pro 15" with no external monitor, so not a massively large dev space and most of my console windows aren't full screen.) I basically no longer use the --help locally; exclusively try to read the docs on the repo for how to use the CLI.

image

@wyardley
Copy link
Contributor

wyardley commented Mar 23, 2023

#862 didn't have "Fixes #797", so this didn't get closed, but should be resolved once #886 goes out and is released.

Thanks @threepipes for making a fix for this!

@elliotforbes
Copy link
Contributor

Closing this as it should have gone live! Thanks again for the contribution @threepipes 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants