Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate follow command #1031

Merged

Conversation

abdelDriowya
Copy link
Contributor

@abdelDriowya abdelDriowya commented Jan 3, 2024

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • deprecate follow command

Rationale

=========

this command is deprecated and is not reliable on Github projects created after September 2023

Screenshots

============
Screenshot 2024-01-03 at 15 28 25

@abdelDriowya abdelDriowya requested a review from a team as a code owner January 3, 2024 14:28
Copy link
Contributor

@jvincent42 jvincent42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abdelDriowya abdelDriowya merged commit c0a1d20 into develop Jan 11, 2024
1 check passed
@abdelDriowya abdelDriowya deleted the DEVEX-1381-cli-deprecate-command-circleci-follow branch January 11, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants