Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIFE-810] Support additional pipeline parameters in config validation #1080

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

kira-m
Copy link
Contributor

@kira-m kira-m commented Nov 8, 2024

Checklist

=========

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Support additional pipeline parameters when running circleci config validate

Note: I did compile the binary, manually verified that it failed when validating a config containing pipeline.trigger_parameters.github_app.user_id. After I made my changes, compiled again and validation passed.

Rationale

=========

These parameters are valid and listed in our documentation; we shouldn't throw errors when users actually try to use them

@kira-m kira-m force-pushed the life-810b branch 4 times, most recently from 178a54b to 9d0aafb Compare November 8, 2024 21:24
@kira-m kira-m marked this pull request as ready for review November 8, 2024 21:43
@kira-m kira-m requested a review from a team as a code owner November 8, 2024 21:43
@kira-m kira-m merged commit 08776cb into develop Nov 12, 2024
1 check passed
@kira-m kira-m deleted the life-810b branch November 12, 2024 19:20
@kira-m kira-m restored the life-810b branch November 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants