Fix gometalinter flakes by setting CGO_ENABLED=0 #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into the lint CI failures in #17 by re-running the job with ssh enabled. In the shell I ran
In the debug output I noticed
Often (maybe always) when you get linter errors reported for
/usr/local/go
this indicates that linting is failing becausego build
failed.The
gometalinter
docker image uses alpine and doesn't includegcc
and all the c header files, so running withCGO_ENABLED=0
fixes the build by using the pure-go compiler.Also added a config file to explicitly define and configure linters. I added a few additional linters that aren't in the default set but which I find helpful (
gosimple
,misspell
,goimports
,nakedret
,unparam
).I also removed
dupl
from the list, which is enabled by default. In my experience the warnings this reports are often not very valuable, but I would be happy to re-enabled it if you would like.